From 5ad5a46cfe539fc038c5c87a7fb1eebb0696abdd Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Fri, 12 Dec 2025 12:37:06 -0800 Subject: [PATCH] GUACAMOLE-2181: Clarify log messages for RADIUS challenge parsing failures. --- .../auth/radius/AuthenticationProviderService.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java b/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java index 23c72911b..c82680288 100644 --- a/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java +++ b/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java @@ -94,14 +94,18 @@ public class AuthenticationProviderService { // Try to get the state attribute - if it's not there, we have a problem RadiusAttribute stateAttr = challengePacket.findAttribute(Attr_State.TYPE); if (stateAttr == null) { - logger.error("Something went wrong, state attribute not present."); + logger.error("RADIUS server did not include the required \"{}\" " + + "attribute in its challenge packet - cannot continue.", + Attr_State.NAME); return null; } // We need to get the reply message so we know what to ask the user RadiusAttribute replyAttr = challengePacket.findAttribute(Attr_ReplyMessage.TYPE); if (replyAttr == null) { - logger.error("No reply message received from the server."); + logger.error("RADIUS server did not include the required \"{}\" " + + "attribute in its challenge packet - cannot continue.", + Attr_ReplyMessage.NAME); return null; }