adam/guacamole-client
1
0 Fork 0
Code Issues Pull Requests 1 Packages Releases Wiki Activity

GUAC-1089: Fix badly broken connection group permission checks.

Browse Source
This commit is contained in:
Michael Jumper committed 2015-02-18 21:41:20 -08:00
1 parent 7b32adad97
commit 8ee7fbecc7
1 file changed
+4 -4
Download Patch File Download Diff File Expand all files Collapse all files
extensions/guacamole-auth-mysql/src/main/java/net/sourceforge/guacamole/net/auth/mysql/ConnectionGroupDirectory.java
+4 -4
View File
@@ -199,9 +199,9 @@ public class ConnectionGroupDirectory implements Directory<String, ConnectionGro
MySQLConnectionGroup mySQLConnectionGroup = (MySQLConnectionGroup) object; MySQLConnectionGroup mySQLConnectionGroup = (MySQLConnectionGroup) object;
// Verify permission to update // Verify permission to update
permissionCheckService.verifyConnectionAccess(currentUser, permissionCheckService.verifyConnectionGroupAccess(currentUser,
mySQLConnectionGroup.getConnectionGroupID(), mySQLConnectionGroup.getConnectionGroupID(),
MySQLConstants.CONNECTION_UPDATE); MySQLConstants.CONNECTION_GROUP_UPDATE);
// Perform update // Perform update
connectionGroupService.updateConnectionGroup(mySQLConnectionGroup); connectionGroupService.updateConnectionGroup(mySQLConnectionGroup);
@@ -252,8 +252,8 @@ public class ConnectionGroupDirectory implements Directory<String, ConnectionGro
if(mySQLConnectionGroup == null) if(mySQLConnectionGroup == null)
throw new GuacamoleResourceNotFoundException("Connection group not found."); throw new GuacamoleResourceNotFoundException("Connection group not found.");
// Verify permission to update the connection // Verify permission to update the connection group
permissionCheckService.verifyConnectionAccess(currentUser, permissionCheckService.verifyConnectionGroupAccess(currentUser,
mySQLConnectionGroup.getConnectionGroupID(), mySQLConnectionGroup.getConnectionGroupID(),
MySQLConstants.CONNECTION_GROUP_UPDATE); MySQLConstants.CONNECTION_GROUP_UPDATE);