Correct typos and error in all comments of the PR
This commit is contained in:
1 parent
00ff730051
commit
9bc2847712
4 files changed
+15
-15
No files matched your search
+8
-8
@@ -339,7 +339,8 @@ public class ConfigurationService {
|
|||||||
* guacamole.properties.
|
* guacamole.properties.
|
||||||
*
|
*
|
||||||
* @throws GuacamoleException
|
* @throws GuacamoleException
|
||||||
* endpoint property is missing.
|
* If guacamole.properties cannot be parsed, or it authorization and
|
||||||
|
* well-known endpoints are property is missing.
|
||||||
*/
|
*/
|
||||||
public URI getAuthorizationEndpoint() throws GuacamoleException {
|
public URI getAuthorizationEndpoint() throws GuacamoleException {
|
||||||
URI authorization_endpoint = environment.getProperty(OPENID_AUTHORIZATION_ENDPOINT);
|
URI authorization_endpoint = environment.getProperty(OPENID_AUTHORIZATION_ENDPOINT);
|
||||||
@@ -396,7 +397,7 @@ public class ConfigurationService {
|
|||||||
*
|
*
|
||||||
* @throws GuacamoleException
|
* @throws GuacamoleException
|
||||||
* If guacamole.properties cannot be parsed, or if the issuer property
|
* If guacamole.properties cannot be parsed, or if the issuer property
|
||||||
* is missing.
|
* and well-known endpoints are property is missing.
|
||||||
*/
|
*/
|
||||||
public String getIssuer() throws GuacamoleException {
|
public String getIssuer() throws GuacamoleException {
|
||||||
String issuer = environment.getProperty(OPENID_ISSUER);
|
String issuer = environment.getProperty(OPENID_ISSUER);
|
||||||
@@ -418,8 +419,8 @@ public class ConfigurationService {
|
|||||||
* guacamole.properties.
|
* guacamole.properties.
|
||||||
*
|
*
|
||||||
* @throws GuacamoleException
|
* @throws GuacamoleException
|
||||||
* If guacamole.properties cannot be parsed, or if the JWKS endpoint
|
* If guacamole.properties cannot be parsed, or if the JWKS and
|
||||||
* property is missing.
|
* well-known endpoints are property is missing.
|
||||||
*/
|
*/
|
||||||
public URI getJWKSEndpoint() throws GuacamoleException {
|
public URI getJWKSEndpoint() throws GuacamoleException {
|
||||||
URI jwks_uri = environment.getProperty(OPENID_JWKS_ENDPOINT);
|
URI jwks_uri = environment.getProperty(OPENID_JWKS_ENDPOINT);
|
||||||
@@ -439,8 +440,8 @@ public class ConfigurationService {
|
|||||||
* guacamole.properties.
|
* guacamole.properties.
|
||||||
*
|
*
|
||||||
* @throws GuacamoleException
|
* @throws GuacamoleException
|
||||||
* If guacamole.properties cannot be parsed, or if the token
|
* If guacamole.properties cannot be parsed, or if the token and
|
||||||
* endpoint property is missing.
|
* well-known endpoints are property is missing.
|
||||||
*/
|
*/
|
||||||
public URI getTokenEndpoint() throws GuacamoleException {
|
public URI getTokenEndpoint() throws GuacamoleException {
|
||||||
URI token_endpoint = environment.getProperty(OPENID_TOKEN_ENDPOINT);
|
URI token_endpoint = environment.getProperty(OPENID_TOKEN_ENDPOINT);
|
||||||
@@ -490,8 +491,7 @@ public class ConfigurationService {
|
|||||||
* as configured with guacamole.properties.
|
* as configured with guacamole.properties.
|
||||||
*
|
*
|
||||||
* @throws GuacamoleException
|
* @throws GuacamoleException
|
||||||
* If guacamole.properties cannot be parsed, or if the client ID
|
* If guacamole.properties cannot be parsed.
|
||||||
* property is missing.
|
|
||||||
*/
|
*/
|
||||||
public String getClientSecret() throws GuacamoleException {
|
public String getClientSecret() throws GuacamoleException {
|
||||||
return environment.getProperty(OPENID_CLIENT_SECRET);
|
return environment.getProperty(OPENID_CLIENT_SECRET);
|
||||||
|
|||||||
+3
-3
@@ -65,12 +65,12 @@ public class OpenIDWellKnown {
|
|||||||
private static String issuer = null;
|
private static String issuer = null;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The detected authorization edpoint
|
* The detected authorization endpoint
|
||||||
*/
|
*/
|
||||||
private static URI authorization_endpoint = null;
|
private static URI authorization_endpoint = null;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The detected token edpoint
|
* The detected token endpoint
|
||||||
*/
|
*/
|
||||||
private static URI token_endpoint = null;
|
private static URI token_endpoint = null;
|
||||||
|
|
||||||
@@ -104,7 +104,7 @@ public class OpenIDWellKnown {
|
|||||||
* guacamole.properties.
|
* guacamole.properties.
|
||||||
*
|
*
|
||||||
* @throws GuacamoleException
|
* @throws GuacamoleException
|
||||||
* If guacamole.properties cannot be parsed, or if the authorization
|
* If guacamole.properties cannot be parsed, or if the well-known
|
||||||
* endpoint property is missing.
|
* endpoint property is missing.
|
||||||
*/
|
*/
|
||||||
private URI getWellKnownEndpoint() throws GuacamoleException {
|
private URI getWellKnownEndpoint() throws GuacamoleException {
|
||||||
|
|||||||
+1
-1
@@ -53,7 +53,7 @@ public final class JsonUrlReader {
|
|||||||
* Method to POST or GET to a URL and recover the JSON in the form of a Map
|
* Method to POST or GET to a URL and recover the JSON in the form of a Map
|
||||||
*
|
*
|
||||||
* @param String method
|
* @param String method
|
||||||
* The htpp method to use. Should be "GET", "POST" or "PATCH".
|
* The http method to use. Should be "GET", "POST" or "PATCH".
|
||||||
*
|
*
|
||||||
* @param URI uri
|
* @param URI uri
|
||||||
* A URI value giving the address where to recover the JSON
|
* A URI value giving the address where to recover the JSON
|
||||||
|
|||||||
+3
-3
@@ -31,7 +31,7 @@ import java.security.SecureRandom;
|
|||||||
*/
|
*/
|
||||||
public final class PKCEUtil {
|
public final class PKCEUtil {
|
||||||
/**
|
/**
|
||||||
* Get the verifier data from a secure random source
|
* Get the verifier data from a cryptographically secure random source
|
||||||
*/
|
*/
|
||||||
private static final SecureRandom RANDOM = new SecureRandom();
|
private static final SecureRandom RANDOM = new SecureRandom();
|
||||||
|
|
||||||
@@ -56,7 +56,7 @@ public final class PKCEUtil {
|
|||||||
* Computes the PKCE code_challenge = BASE64URL(SHA256(code_verifier)).
|
* Computes the PKCE code_challenge = BASE64URL(SHA256(code_verifier)).
|
||||||
*
|
*
|
||||||
* @param String verifier
|
* @param String verifier
|
||||||
* A string containing the S56 verifier calculated bu generateCodeVerifier
|
* A string containing the S256 verifier calculated bu generateCodeVerifier
|
||||||
*
|
*
|
||||||
* @return
|
* @return
|
||||||
* The generated S256 code challenge used for the PKCE request encoded
|
* The generated S256 code challenge used for the PKCE request encoded
|
||||||
@@ -72,7 +72,7 @@ public final class PKCEUtil {
|
|||||||
* Base64URL encoding without padding.
|
* Base64URL encoding without padding.
|
||||||
*
|
*
|
||||||
* @param bytes
|
* @param bytes
|
||||||
* The bytes to be Base54 URL encoded
|
* The bytes to be Base64 URL encoded
|
||||||
*
|
*
|
||||||
* @return
|
* @return
|
||||||
* The Base64 URL encoded string value corresponding to the bytes
|
* The Base64 URL encoded string value corresponding to the bytes
|
||||||
|
|||||||
Reference in new issue
Block a user