Commit Graph
424 Commits
Author SHA1 Message Date
Michael Jumper 49cd4e5531 GUACAMOLE-524: Clarify and document SimpleConnection implementation. 2019-01-21 22:04:44 -08:00
Michael Jumper 6be722ed9d GUACAMOLE-524: Require usages of SimpleConnection to explicitly request automatic interpretation of parameter tokens. Do not enable by default.
Previous implementations of SimpleConnection did not interpret parameter
tokens automatically. Adding that behavior now could have security
implications for downstream users of the class if parameter values may
unexpectedly contain substrings which would be interpreted as tokens,
particularly if parameter values are built from untrusted input.
2019-01-21 19:55:33 -08:00
Michael Jumper 7e67dde751 GUACAMOLE-524: Leverage thread-local storage to allow overriding the deprecated connect() function to have the expected effect within subclasses of SimpleConnection. 2019-01-21 17:52:54 -08:00
Michael Jumper b638387920 GUACAMOLE-524: Provide distinct, documented, internal access to raw GuacamoleConfiguration within SimpleConnection.
While raw, internal access to the GuacamoleConfiguration was originally
present in older versions of SimpleConnection, this access was
undocumented and could result in unexpected behavior if the default
constructor was used, getConfiguration() was overridden, or
setConfiguration() was called.
2019-01-21 17:38:24 -08:00
Michael Jumper 4a1527b1d4 GUACAMOLE-524: Provide bridge implementations of both old and new versions of connect() for sake of compatibility. 2019-01-20 13:30:55 -08:00
James Muehlner d4f58f2c0d Merge changes from 1.0.0 back to master. 2018-11-08 22:18:28 -08:00
Michael Jumper 95b5fdccdc GUACAMOLE-656: Explicitly depend on maven-surefire-plugin 3.0.0-M1 due to SUREFIRE-1588. 2018-11-08 22:09:35 -08:00
James Muehlner 756ec2fcc4 Merge 1.0.0 changes back to master. 2018-11-08 21:26:43 -08:00
Michael Jumper b355106c77 GUACAMOLE-220: Remove unnecessary explicit type parameters. 2018-11-08 20:11:17 -08:00
Michael Jumper 2d6ba84a3d GUACAMOLE-220: Refactor default behavior of SimpleUser and SimpleUserGroup into AbstractUser and AbstractUserGroup. 2018-11-03 14:52:24 -07:00
Michael Jumper 90a6d8e371 GUACAMOLE-220: Clarify usage of SimpleUser and SimpleUserGroup. 2018-11-03 14:14:04 -07:00
Michael Jumper d533de118f GUACAMOLE-220: Add EMPTY_SET convenience constant to all core set interfaces. 2018-11-03 14:08:46 -07:00
Michael Jumper d10256e151 GUACAMOLE-220: Deprecate built-in support for storage of permissions in SimpleUser. Add convenience constructors for SimpleObjectPermissionSet. 2018-11-03 13:58:50 -07:00
Michael Jumper 929c7de2c9 GUACAMOLE-220: Add user group permissions to SimpleUser. 2018-11-03 12:41:54 -07:00
Michael Jumper 5362bc6708 GUACAMOLE-220: Add SimpleUserGroup (read-only UserGroup implementation with no members). 2018-11-03 12:41:54 -07:00
Michael Jumper 143c10b6ef GUACAMOLE-524: Correct handling of tokens within SimpleConnection. The copy of the configuration should be filtered, not the original, and token values need to actually be set. 2018-10-16 14:53:10 -07:00
Michael Jumper 333a8c411f GUACAMOLE-524: Provide convenience constructor for TokenFilter which initializes the filter with provided tokens. 2018-10-16 14:53:10 -07:00
Michael Jumper 98bd3ead21 GUACAMOLE-524: Remove Attributes interface from AuthenticatedUser. Rely instead on tokens injected via decoration of connections. 2018-10-05 12:47:26 -07:00
Michael Jumper 0d7cff5f2d GUACAMOLE-524: Add convenience classes for injecting custom parameter tokens through decoration. 2018-10-05 12:47:26 -07:00
Michael Jumper 1210d5624c GUACAMOLE-524: Deprecate and replace StandardTokens with arbitrary tokens provided to Connectable.connect(). 2018-10-05 12:47:26 -07:00
Nick Couchman 01709fb26b Merge 1.0.0 changes back to master. 2018-10-05 15:13:36 -04:00
Michael Jumper 11c1d8c97e GUACAMOLE-96: Add protected convenience method for retrieving delegate object. 2018-10-05 10:36:47 -07:00
Nick Couchman d1a6c297b8 Merge 1.0.0 changes back to master. 2018-09-29 16:50:32 -04:00
Michael Jumper 182f204c95 GUACAMOLE-635: Heap pollution is not possible within SimpleDirectory(ObjectType... objects).
From https://docs.oracle.com/javase/tutorial/java/generics/nonReifiableVarargsType.html#vulnerabilities:

"Heap pollution occurs when a variable of a parameterized type refers
to an object that is not of that parameterized type."

In this case, the parameterized type (ObjectType) and the array of that
type within this constructor are always used as their formal types.
2018-09-29 13:19:21 -07:00
Michael Jumper 1fef6a05e1 GUACAMOLE-635: Require Java 1.8 for all Java components except guacamole-common. 2018-09-29 12:56:17 -07:00
Michael Jumper af8f5b3a80 GUACAMOLE-622: Add parameter definitions for telnet login success/failure regex. 2018-09-21 17:33:44 -07:00
Nick Couchman d320606295 Merge 1.0.0 changes to master. 2018-09-08 18:42:08 -04:00
Michael Jumper 3492b556c3 GUACAMOLE-220: Add missing definitions for CREATE_USER_GROUP system permission. 2018-09-08 13:09:24 -07:00
Michael Jumper 661ed46098 Merge 1.0.0 changes back to master. 2018-07-05 23:56:56 -07:00
Michael Jumper d6ecfaa369 GUACAMOLE-446: Merge parameter definition for RDP drive name. 2018-07-05 23:55:49 -07:00
Nick Couchman c4b5fb7146 GUACAMOLE-446: Add parameters and translations for drive name. 2018-07-03 22:31:24 -04:00
Nick Couchman b4b7366b84 GUACAMOLE-445: Add client-side parameters and translations for changing printer name. 2018-07-02 20:40:39 -04:00
Michael Jumper d53b43ce29 Merge 1.0.0 changes back to master. 2018-07-01 23:18:04 -07:00
Michael Jumper 34faa5d928 GUACAMOLE-540: Merge changes ensuring remote addresses are handled/logged consistently across the various parts of the webapp. 2018-07-01 23:09:08 -07:00
Nick Couchman 2ff416bb1c GUACAMOLE-540: Remove unused imports. 2018-06-30 14:31:24 -04:00
Nick Couchman 3d593a4ca1 GUACAMOLE-540: Remove processing of X-Forwarded-For header. 2018-06-30 14:28:53 -04:00
Michael Jumper d1e928bea7 Merge 1.0.0 changes back to master. 2018-06-27 21:04:33 -07:00
Nick Couchman 39f5cb4a2c GUACAMOLE-527: Change multiline to single line text field. 2018-06-26 15:41:45 -04:00
Nick Couchman db8bb9f85a GUACAMOLE-527: Correct order of options in RDP and VNC. 2018-06-26 15:39:25 -04:00
Nick Couchman 50e3e4ab94 GUACAMOLE-527: Add fields for known host key for servers. 2018-06-25 08:42:33 -04:00
Nick Couchman a9637494ac GUACAMOLE-524: Merge allow user attributes to be used as tokens. 2018-06-21 11:14:06 -04:00
Jared Frees 927c04b9d4 GUACAMOLE-524: Removed unused imports, fixed comments, and condensed
code
2018-06-21 11:02:18 -04:00
Nick Couchman 0b77782391 GUACAMOLE-540: Fix spaces that get added by IDE 2018-06-16 08:07:33 -04:00
Nick Couchman fb1efec056 GUACAMOLE-540: Restore removed setter methods in Credentials. 2018-06-16 08:06:13 -04:00
Nick Couchman a0d0e07658 GUACAMOLE-540: Clean up style and comments in Credentials class 2018-06-16 08:06:07 -04:00
Nick Couchman 52a3f454e6 GUACAMOLE-540: Clean up Credentials with new constructor. 2018-06-16 08:06:07 -04:00
Nick Couchman c725da00a0 GUACAMOLE-540: Update comments; remove unnecessary setter methods. 2018-06-16 07:13:17 -04:00
Nick Couchman cbd77b52ae GUACAMOLE-540: Move remote address processing to Credentials class for consistency. 2018-06-16 07:13:17 -04:00
Jared Frees 0964c46f4f GUACAMOLE-524: Fixed RegEx for attribute tokens by removing ':' 2018-06-15 10:53:18 -04:00
Jared Frees 653b4e0134 Updated JavaDoc for addStandardTokens 2018-06-14 11:15:57 -04:00