Commit Graph
1170 Commits
Author SHA1 Message Date
Michael Jumper 2cb0efeda6 GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to interpret and handle failures.
Throwing GuacamoleInvalidCredentialsException breaks separation of
concerns (bindAs() shouldn't assume that it's being used during login
and that credentials given are the Guacamole user's credentials), and
has unintended side effects (throwing subclasses of
GuacamoleUnauthorizedException causes implicit session invalidation).
2020-01-23 23:24:47 -08:00
Michael Jumper 00327706b0 GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are leaked, causing Tomcat to fail to shutdown. 2020-01-22 22:07:11 -08:00
Michael Jumper 76c1b0f9bb GUACAMOLE-929: Update copyright date to 2020. 2020-01-19 13:39:54 -08:00
Virtually Nick a037146a87 GUACAMOLE-893: Fix issue where just checking for attribute presence. 2019-10-10 20:53:07 -04:00
Virtually Nick 10b3adcd83 GUACAMOLE-893: Fix regression in LDAP causing null filter value to be sent. 2019-10-09 14:53:34 -04:00
Mike Jumper 981adc94e6 GUACAMOLE-699: Merge changes bringing German translations up-to-date. 2019-09-09 18:52:53 -07:00
Nick Couchman 610ed6934e GUACAMOLE-234: Fix bind issue that occurs using try-with-resources. 2019-08-26 11:19:35 -04:00
leetxyz 5ac68c3f72 GUACAMOLE-699: Fix language ordering, add de.json to auth-jdbc-*, fix intendation 2019-08-15 18:09:30 +02:00
leetxyz 222ac78576 GUACAMOLE-699: Various fixes according to comments in PR 2019-08-12 21:02:36 +02:00
Virtually Nick 749da7d29c GUACAMOLE-234: Fix resource leaks in new LDAP code. 2019-08-12 13:03:31 -04:00
Virtually Nick 1d205fd451 GUACAMOLE-360: Merge add support for joining active connections without share links. 2019-08-11 19:03:05 -04:00
Virtually Nick 11f7a7f3c7 GUACAMOLE-234: Update license files. 2019-08-11 18:37:43 -04:00
Michael Jumper 403431bf92 GUACAMOLE-360: Add support for joining active connections to the database auth. 2019-08-11 14:30:31 -07:00
Virtually Nick 8b172a98fc GUACAMOLE-234: Fix style, debug messages, and logger output. 2019-08-10 22:14:56 -04:00
Virtually Nick 8c1a3f3435 GUACAMOLE-234: Remove stray catch block. 2019-08-10 13:57:51 -04:00
Virtually Nick 5ea518a390 GUACAMOLE-234: Update to latest available Apache Directory API. 2019-08-10 13:57:51 -04:00
Nick Couchman ed568b1f55 GUACAMOLE-234: Tweaks to handling bind requests/failures. 2019-08-10 13:57:51 -04:00
Nick Couchman 742b0c4e65 GUACAMOLE-234: Correctly handle bind failure. 2019-08-10 13:57:51 -04:00
Nick Couchman 791cfeabbb GUACAMOLE-234: Only try LDAP bind if user authenticated with LDAP. 2019-08-10 13:57:51 -04:00
Nick Couchman fc5c4c538e GUACAMOLE-234: Don't close the connection after bind. 2019-08-10 13:57:51 -04:00
Nick Couchman d7d622051f GUACAMOLE-234: Change EqualityNode to PresenceNode for wildcard objectClass. 2019-08-10 13:57:51 -04:00
Nick Couchman 72dad76d42 GUACAMOLE-234: Adjust LDAP filters. 2019-08-10 13:57:51 -04:00
Nick Couchman 7825f57b99 GUACAMOLE-234: Correct counter for referral hops. 2019-08-10 13:57:51 -04:00
Nick Couchman 7a17b7f935 GUACAMOLE-234: Add storage for the LDAP Bind DN to LDAPAuthenticateduser. 2019-08-10 13:57:51 -04:00
Nick Couchman d0b1d7639e GUACAMOLE-234: Clean up comments, instanceof, and type-casting. 2019-08-10 13:57:09 -04:00
Nick Couchman 4aa4489b78 GUACAMOLE-234: Correct LDAP filter mispelling. 2019-08-10 13:56:12 -04:00
Nick Couchman 288fcb5e13 GUACAMOLE-234: Exclude slf4j from Apache Directory dependency. 2019-08-10 13:56:11 -04:00
Nick Couchman 41e3b8ca56 GUACAMOLE-234: Clean up comments. 2019-08-10 13:56:11 -04:00
Nick Couchman 5777d93fdc GUACAMOLE-234: Clean up some LDAP implementation details. 2019-08-10 13:56:11 -04:00
Nick Couchman 2f1fac51af GUACAMOLE-234: Convert LDAP extension to use Apache Directory LDAP API. 2019-08-10 13:56:11 -04:00
Virtually Nick 9c26a7613c GUACAMOLE-579: Remove unnecessary JUnit dependencies. 2019-06-22 20:02:46 -04:00
Virtually Nick 7f26ba7a52 GUACAMOLE-579: Insure that CAS is providing a username. 2019-06-22 19:27:52 -04:00
Virtually Nick a6601a2bfd GUACAMOLE-579: Change fromAttribute to canonicalize 2019-06-21 12:54:42 -04:00
Virtually Nick d8db630dbd GUACAMOLE-579: Clean up comments, implement convenience method for tokens without a prefix, and remove unneeded classes. 2019-06-20 20:41:41 -04:00
Virtually Nick 8ab9e51009 GUACAMOLE-579: Put back original init method for compatibility. 2019-06-20 19:52:06 -04:00
Nick Couchman 55c4144fbf GUACAMOLE-579: Parse tokens from attributes provided by the CAS server. 2019-06-20 19:52:06 -04:00
Michael Jumper 1c1fac700c GUACAMOLE-807: Correct handling of parameter tokens within LDAP.
Parameter tokens are intended to be interpreted by the connections
stored within LDAP. This was previously done through explicitly using a
TokenFilter and the StandardTokens class, however usage of
StandardTokens is now deprecated and the values of tokens to be applied
are now expected to be received through connect(). Usage of
StandardTokens was removed from LDAP with commit 1210d56, but this is
insufficient. An additional parameter must also be provided to the
SimpleConnection constructor to enable its automatic token handling
behavior.
2019-06-07 08:39:30 -07:00
Mike Jumper 4d1e0f18dd GUACAMOLE-696: Merge changes taking database groups into account with respect to database objects when user is otherwise external to the database. 2019-05-05 19:36:37 -07:00
Virtually Nick 9158ca68e3 GUACAMOLE-696: Use Guava Sets to combine the user groups. 2019-05-05 21:16:44 -04:00
Michael Jumper 61b6664eac GUACAMOLE-715: Include all provided effective user groups that exist within the database in results of effective groups query, regardless of whether the user is declared as a member of those groups within the database.
While this query is generally functioning as described above for all
supported databases, it is not functioning properly for the
non-recursive variant of the MySQL/MariaDB query. This change corrects
that behavior.
2019-04-21 12:02:25 -07:00
Nick Couchman 52d6a6aff8 GUACAMOLE-715: Provide skeleton ModeledUser when none exists in DB. 2019-04-09 13:05:33 -04:00
leetxyz ca9b535a22 GUACAMOLE-699: Add german translations to extension guac-manifests 2019-03-01 22:07:13 +01:00
leetxyz 03499c113f GUACAMOLE-699: Update german translation 2019-03-01 21:55:00 +01:00
Virtually Nick e1fea889ca GUACAMOLE-696: In JDBC module, merge effective groups. 2019-02-21 20:37:36 -05:00
Michael Jumper c3fbf44f70 GUACAMOLE-729: Bump version numbers to 1.1.0. 2019-02-09 11:08:28 -08:00
Joel Best 93d80418ba GUACAMOLE-717: Handle LDAPException gracefully when processing LDAP search results 2019-01-25 20:36:43 -05:00
Mike Jumper df7404f4cb GUACAMOLE-693: Merge update to NOTICE copyright year (2018 -> 2019). 2019-01-24 16:43:48 -08:00
Nick Couchman ba198398e0 GUACAMOLE-697: Add DISTINCT to selectOne permissions queries. 2019-01-24 07:53:22 -05:00
Nick Couchman af2ef32fc3 GUACAMOLE-693: Update copyright year to 2019. 2019-01-23 17:12:45 -05:00
Michael Jumper 6be722ed9d GUACAMOLE-524: Require usages of SimpleConnection to explicitly request automatic interpretation of parameter tokens. Do not enable by default.
Previous implementations of SimpleConnection did not interpret parameter
tokens automatically. Adding that behavior now could have security
implications for downstream users of the class if parameter values may
unexpectedly contain substrings which would be interpreted as tokens,
particularly if parameter values are built from untrusted input.
2019-01-21 19:55:33 -08:00