openid fixes from GUACAMOLE-2258 #1

2026-04-13T14:52:37Z

adam commented

2026-04-13 14:52:37 +00:00

https://github.com/apache/guacamole-client/pull/1198/commits

adam added 14 commits 2026-04-13 14:52:37 +00:00

Add code flow authorisation type, with or without a client secret and with or without pkce 4b5ed08b00

Use SessionManager directly from getLoginURI to store PKCE removing the need for local REST redirect and callback function 95f9d525ae

Reinclude accidentally removed check if implicit token is null 5af9d38a7c

Minor white-spece, import changes to minimize impact on existing code f930e76bfa

Remove accidentally committed files 4dfb4b5c66

- Add openid-well-known-endpoint and treat it to automatically find the : 08bcd1f9e8

* issuer,
  * authorization_endpoint,
  * token_endpoint,
  * jwks_uri
- Replace openid-flow-type with openid-response-type
- Use an Enum for openid-response-type to limit to the values 'id_token',
  'token' or 'cod'
- Treat the response type as an implicit flow type allowing use of AWS
  Cognito

Treat review comments ae22b4116a

Remove some no longer used imports for TokenValidationService 64f0abeafb

Print detected OIDC well-known information at debug-level equals info a48665bf60

Replace use of java.net.HttpURLConnection with jav.net.http.HttpClient, make the outboud url connection asynchronous 21e97e480c

No body in JsonUrlReader for GET method b302cf5276

Replace openid-auth-timeout with openid-max-pkce-verifier-validity for consistency with openid-max-nonce-validity 024a69695c

Copy/Paste editing error fd0ae00836

Stupid cut/paste/edit mistake 00ff730051

adam added 1 commit 2026-04-15 12:14:15 +00:00

Correct typos and error in all comments of the PR 9bc2847712

This branch is already included in the target branch. There is nothing to merge.

View command line instructions