History diff: keep a stepped-back object in place; number hunks right
Rewind put an object's old form at the end of its list, so a history entry's diff showed the changed object moving (turning hairpin off for one forward also moved its forward and DNAT lines). It now sorts after stepping back. go-udiff v0.4.1 numbers the new side of hunks after one with a moved line too early, so the chain after @@ could be the one before; hunkStarts numbers them again. History diffs name their sides "before N" and "after N". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
540f4b85ac
commit
0d16358617
4 files changed
+143
-2
No files matched your search
@@ -142,6 +142,16 @@ All notable changes to Housecarl are documented here. The format follows
|
||||
|
||||
### Fixed
|
||||
|
||||
- A history entry's ruleset diff showed the object it changed as moved:
|
||||
stepping back put the old form at the end of its list, so updating
|
||||
one port forward (turning hairpin off) also showed its forward and
|
||||
DNAT lines moving down. The diff is now only what the change did, and
|
||||
its sides are named `before N` and `after N` instead of `now`.
|
||||
- Ruleset diffs numbered the hunks after one with a moved line too early
|
||||
on the new side (`@@ -76,9 +74,9 @@` for `+76,9`), so the chain named
|
||||
after `@@` could be the one before (`chain output` for a hunk in
|
||||
`chain dstnat`). go-udiff miscounts them; Housecarl now numbers them
|
||||
itself.
|
||||
- The dashboard's bar for a per-address quota showed only the busiest
|
||||
address, so one address that used up its allowance filled it (100%).
|
||||
The bar is now all the addresses together, and the dashboard and the
|
||||
|
||||
Reference in new issue
Block a user