update stuff

ansible/roles/win_update/tasks/update.yml

@@ -1,14 +1,10 @@
 ---
-- name: Install client VM updates and reboot as much as needed
+- name: Install all updates and reboot as many times as needed
+  tags: update_windows1
   block:
     - name: Install Windows updates (looped)
-      tags: update_windows
       ansible.windows.win_updates:
-        category_names:
-          - CriticalUpdates
-          - DefinitionUpdates
-          - SecurityUpdates
-          - UpdateRollups
+        category_names: '*'
         reboot: true
       register: update_result
       retries: 5
@@ -16,50 +12,59 @@
       until: update_result.reboot_required == false
 
     - name: Wait for host to come back online
-      tags: update_windows
       ansible.builtin.wait_for_connection:
         timeout: 600
 
-    - name: Update all choco packages
-      win_command: choco upgrade all -y
-      tags: update_choco
-
-    - name: Update Start Menu Shortcuts in XML on remote Windows machines
-      tags: update_start_menu
-      block:
-        - name: Copy Python script to target machine
-          ansible.windows.win_template:
-            src: "{{ script_name }}"
-            dest: "{{ script_path }}"
-            force: true
-
-        - name: Copy current XML to backup location
-          win_copy:
-            remote_src: true
-            src: "{{ start_menu_xml }}"
-            dest: "{{ backup_xml }}"
-
-        - name: Run Python script on remote machine
-          win_command: python "{{ script_path }}.xml"
-  when: "inventory_hostname in groups['meta-type_client']|default([])"
-
-- name: Install Server VM updates and reboot as much as needed
+- name: Install all Windows updates and reboot if required
   tags: update_windows
   block:
-    - name: Install Windows updates (looped)
+    - name: Install Windows updates (no auto reboot)
       ansible.windows.win_updates:
-        category_names:
-          - CriticalUpdates
-          - DefinitionUpdates
-          - SecurityUpdates
-          - UpdateRollups
-        reboot: true
+        category_names: '*'
+        reboot: false
       register: update_result
-      retries: 5
-      delay: 30
-      until: update_result.reboot_required == false
 
-    - name: Wait for host to come back online
+    - name: Reboot the machine if updates require it
+      ansible.windows.win_reboot:
+      when: update_result.reboot_required
+
+    - name: Wait for the host to come back online
       ansible.builtin.wait_for_connection:
         timeout: 600
-  when: "inventory_hostname in groups['meta-type_server']"
+
+- name: Update all choco packages
+  tags: update_choco
+  block:
+    - name: Run Chocolatey upgrade (allow failure, don't mark as failed)
+      win_command: choco upgrade all -y --ignore-checksums --failonunfound --continue-on-failure
+      register: choco_result
+      ignore_errors: true
+      failed_when: false  # << This prevents Ansible from treating it as a failed task
+
+    - name: Show Chocolatey output
+      debug:
+        var: choco_result
+
+- name: Update Start Menu Shortcuts in XML on remote Windows machines
+  tags: update_start_menu
+  block:
+    - name: Copy Python script to target machine
+      ansible.windows.win_template:
+        src: "{{ script_name }}"
+        dest: "{{ script_path }}"
+        force: true
+  
+    - name: Copy current XML to backup location
+      win_copy:
+        remote_src: true
+        src: "{{ start_menu_xml }}"
+        dest: "{{ backup_xml }}"
+
+    - name: Run Python script on remote machine
+      win_command: python "{{ script_path }}"
+      register: output
+
+    - name: debug
+      debug:
+        var: output
+