Commit Graph
5527 Commits
Author SHA1 Message Date
Virtually Nick f00f6d6935 GUACAMOLE-1152: Merge correct handling of client vs. server exceptions. 2020-08-20 12:19:25 -04:00
Michael Jumper 2ffe8d9705 GUACAMOLE-1152: Ensure field values accurately represent login state.
If expected fields are deleted rather than reset to empty, those fields
will not be resubmitted in future requests, resulting in the content of
those requests not accurately representing true client-side login state.

For example, if a user receives an insufficient credentials error due to
their password expiring, failing to provide any new password should
result in at least the following fields:

 1. Their original username (part of the initial login attempt)
 2. Their original password (part of the initial login attempt)
 3. Their new password (empty)

If fields are incorrectly reset to null, those fields will not be
submitted, resulting instead in a request containing only:

 1. Their original username (part of the initial login attempt)
 2. Their original password (part of the initial login attempt)

which is indistinguishable from a normal login attempt.
2020-08-19 14:32:45 -07:00
Michael Jumper 10e47a19ff GUACAMOLE-1152: Correctly differentiate between client errors and server errors.
By definition, a client error is not an internal error, but an
intentional refusal of the server to handle a malformed or otherwise
invalid request. These should not be handled in the same way as server
errors which unexpectedly block processing of a request and should be
corrected by an administrator.

In the case of GUACAMOLE-1152, client errors should not be ignored even
if failures are explicitly configured as tolerated for the associated
authentication provider.
2020-08-17 16:48:52 -07:00
Virtually Nick d4fb1b0549 GUACAMOLE-1135: Merge return MySQL StoreUrls in URI format 2020-08-05 16:17:27 -04:00
Richard Grime d32ebd656a GUACAMOLE-1135: Return StoreUrls in URI format 2020-08-05 08:52:54 +00:00
Virtually Nick 21eb3b4e23 GUACAMOLE-1147: Merge add support for additional LDAP properties in Docker container 2020-08-04 11:18:08 -04:00
Virtually Nick d4fdafef23 GUACAMOLE-1150: Merge fix for correctly checking connection group permissions. 2020-08-04 11:12:50 -04:00
quantumhu 5d64a842d0 GUACAMOLE-1150: Fix for correctly checking connection group permissions. 2020-08-04 09:59:13 -04:00
Erwan 4ba33dcbc0 GUACAMOLE-1147: Add all ldap attributes from the doc 2020-08-03 20:32:52 +02:00
Erwan 2f42b90f86 GUACAMOLE-1147: Add ldap-member-attribute-type support for Docker 2020-07-29 15:42:27 +02:00
Virtually Nick 9863aec9f6 GUACAMOLE-919: Merge implement PostgreSQL defaultStatementTimeout and socketTimeout 2020-07-29 08:17:02 -04:00
Virtually Nick 8d864bea64 GUACAMOLE-1082: Merge add guacamole-auth-cas to Docker script 2020-07-29 08:10:48 -04:00
Douglas Heriot a1922b6fdb GUACAMOLE-919: Whitespace fix 2020-07-27 13:36:56 +10:00
Douglas Heriot 20b1dbf00f GUACAMOLE-919: More updates to style and comments. 2020-07-27 13:36:52 +10:00
Douglas Heriot 6cf9787f7b GUACAMOLE-919: Fix style issues, improve comments. 2020-07-27 13:36:48 +10:00
Douglas Heriot 0528ca0564 GUACAMOLE-919: make defaultStatementTimeout an int
More consistent with how socketTimeout.

MyBatis documentation says only positive integers are valid,
and property should not be set otherwise.
So in the case of 0 the property will not be set.
2020-07-27 13:36:40 +10:00
Douglas Heriot 306e1ad3ab GUACAMOLE-919: pass postgres driver socketTimout 2020-07-27 13:36:36 +10:00
Douglas Heriot 34130f54c9 GUACAMOLE-919: pass through defaultStatementTimeout
Testing a workaround for handling dropped TCP connections to the Postgres database.
2020-07-27 13:36:26 +10:00
Virtually Nick c247a1cfcd GUACAMOLE-1136: Merge return correct MYSQL_SSL_CLIENT_ properties 2020-07-25 20:21:45 -04:00
Jordi Roman 70f331c76d GUACAMOLE-1082: guacamole-docker scripts with guacamole-auth-cas 2020-07-21 13:49:12 +02:00
Virtually Nick 8e77864e63 GUACAMOLE-980: Merge migrate Docker image to JDK8 2020-07-20 06:26:02 -04:00
asutosh936 9385c123aa GUACAMOLE-980: used tomcat-jre8 Docker-Image seems to be deprecated 2020-07-19 21:27:36 -05:00
Richard Grime fea3fd3b77 GUACAMOLE-1136: Return correct MYSQL_SSL_CLIENT_
MySQL Environment incorrectly returned MYSQL_SSL_TRUST_
parameters for the file and password, instead of the
expected MYSQL_SSL_CLIENT_ values.
2020-07-14 18:20:26 +00:00
Mike Jumper 3c4c81f0b6 GUACAMOLE-1120: Merge removal of CAS extension resources that no longer exist. 2020-07-08 00:33:17 -07:00
Virtually Nick 699e262501 GUACAMOLE-857: Merge add guacamole-auth-header to Docker image 2020-07-07 12:25:11 -04:00
Jeremy Frasier 8be628a549 GUACAMOLE-857: Configure and use header auth extension if specified 2020-07-07 12:05:54 -04:00
Jeremy Frasier ba089c0135 GUACAMOLE-857: Copy the header auth extension if it is built 2020-07-07 11:16:21 -04:00
Virtually Nick 0d32579557 GUACAMOLE-1123: Merge extract common base REST resources for representing ActivityRecordSets. 2020-07-07 00:10:54 -04:00
Michael Jumper 426d867865 GUACAMOLE-1123: Extract common base REST resources for representing ActivityRecordSets. 2020-07-06 18:13:36 -07:00
Virtually Nick 5fe031c931 GUACAMOLE-1125: Merge fix substituteKeysPressed handler on guacKeyup events 2020-07-06 11:58:01 -04:00
Edgardo Rodriguez 253b987cbb GUACAMOLE-1125: Fix substituteKeysPressed handler on guacKeyup events 2020-07-06 12:44:28 -03:00
Virtually Nick a0345f44db GUACAMOLE-1120: Remove remaining JS, CSS, and HTML components from CAS guac-manifest.json 2020-07-02 09:36:39 -04:00
Michael Jumper 475d9419cc Merge 1.2.0 changes back to master. 2020-06-25 19:25:53 -07:00
Mike Jumper 21ec5640a5 GUACAMOLE-728: Merge changes leveraging PostgreSQL's legacy "ssl" parameter only for disabling SSL. 2020-06-25 19:25:22 -07:00
Virtually Nick 82168e1d77 GUACAMOLE-728: Only set legacy flag when SSL is disabled. 2020-06-25 22:21:04 -04:00
Michael Jumper 038e87a1c6 Merge 1.2.0 changes back to master. 2020-06-25 19:04:43 -07:00
Mike Jumper e3e62f5860 GUACAMOLE-728: Merge workaround for older PostgreSQL drivers lacking support for sslmode "prefer". 2020-06-25 19:03:53 -07:00
Virtually Nick d5d4f16782 GUACAMOLE-728: Handle lack of support for Postgres prefer SSL mode. 2020-06-25 22:01:02 -04:00
Michael Jumper f94e7046ff Merge 1.2.0 changes back to master. 2020-06-25 17:55:48 -07:00
Mike Jumper c71107e395 GUACAMOLE-728: Merge workaround for legacy Connector/J SSL behavior.
Older versions of the MySQL / MariaDB driver do not support the same level of granular SSL/TLS control, and the legacy "useSSL" parameter cannot be specified without breaking the behavior of "sslMode".
2020-06-25 17:54:36 -07:00
Virtually Nick 6fc09f4ee8 GUACAMOLE-728: Only set MySQL JDBC useSSL when sslmode is disabled. 2020-06-25 20:22:20 -04:00
Michael Jumper f37e5e8214 Merge 1.2.0 changes back to master. 2020-06-25 15:54:42 -07:00
Mike Jumper 079b009325 GUACAMOLE-728: Merge update of default JDBC SSL mode to prefer / preferred. 2020-06-25 15:52:57 -07:00
Virtually Nick 788395ad9d GUACAMOLE-728: Change default JDBC SSL mode to prefer(red). 2020-06-25 18:48:07 -04:00
Virtually Nick 5aebe980b8 Merge staging/1.2.0 changes back to master. 2020-06-25 16:23:16 -04:00
Virtually Nick 2522b37997 GUACAMOLE-823: Update item structure of Guacamole menu connection browser to match home screen. 2020-06-25 16:22:30 -04:00
Michael Jumper b5eca6831d GUACAMOLE-823: Update item structure of Guacamole menu connection browser to match home screen. 2020-06-25 13:17:46 -07:00
Virtually Nick 2d233e090f Merge staging/1.2.0 changes back to master. 2020-06-25 06:52:23 -04:00
Virtually Nick 57378fd38f GUACAMOLE-103: Merge transform username only if present. 2020-06-25 06:51:39 -04:00
Michael Jumper 9d415469f8 GUACAMOLE-103: Transform username only if present. 2020-06-24 20:34:52 -07:00